[webkit-reviews] review granted: [Bug 193048] [iOS] Pressing Tab key doesn't move to next cell with Google Sheets : [Attachment 358185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 14:32:07 PST 2019


Daniel Bates <dbates at webkit.org> has granted  review:
Bug 193048: [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
https://bugs.webkit.org/show_bug.cgi?id=193048

Attachment 358185: Patch

https://bugs.webkit.org/attachment.cgi?id=358185&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 358185
  --> https://bugs.webkit.org/attachment.cgi?id=358185
Patch

I changed my mind. The original patch is OK as-is so long as it lands before
bug #192824. When I r-'ed this patch it was before I had amended the patch on
bug #192824 to support tab cycling from a focused <select> (and I got confused
as to which patch was to blame - this one or the one on bug #192824 since I
have both applied in my local repo :P). I've sorted it out, want this patch to
land first, and updated the patch for bug #192824 to ensure it will not regress
the fix made in this patch.

Filed bug #193846 to add tests for this change.


More information about the webkit-reviews mailing list