[webkit-reviews] review granted: [Bug 193782] Complete the implementation of generate-xcfilelists : [Attachment 360051] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 25 13:48:22 PST 2019
Alex Christensen <achristensen at apple.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 193782: Complete the implementation of generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=193782
Attachment 360051: Patch
https://bugs.webkit.org/attachment.cgi?id=360051&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 360051
--> https://bugs.webkit.org/attachment.cgi?id=360051
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review
Nothing jumps out as horribly wrong.
> Tools/Scripts/generate-xcfilelists:1
> +#!/bin/bash
bash?!?!
More information about the webkit-reviews
mailing list