[webkit-reviews] review denied: [Bug 193838] Web Inspector: REGRESSION: selecting a path component with no siblings does nothing : [Attachment 360150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 13:37:21 PST 2019


Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 193838: Web Inspector: REGRESSION: selecting a path component with no
siblings does nothing
https://bugs.webkit.org/show_bug.cgi?id=193838

Attachment 360150: Patch

https://bugs.webkit.org/attachment.cgi?id=360150&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 360150
  --> https://bugs.webkit.org/attachment.cgi?id=360150
Patch

r-, as I don't think removing allowsRepeatSelection is the right fix for this.

We rely on allowsRepeatSelection in the Debugger tab Call Stack tree. Selecting
an already selected element should scroll the source code location into view.
This change breaks that behavior.


More information about the webkit-reviews mailing list