[webkit-reviews] review denied: [Bug 193786] Turn on Smart Paste : [Attachment 360133] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 193786: Turn on Smart Paste
https://bugs.webkit.org/show_bug.cgi?id=193786

Attachment 360133: Patch

https://bugs.webkit.org/attachment.cgi?id=360133&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 360133
  --> https://bugs.webkit.org/attachment.cgi?id=360133
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360133&action=review

> LayoutTests/editing/pasteboard/smart-paste-001.html:49
> +    if (UIHelper.isIOS())
> +	   getSelection().setBaseAndExtent(test.firstChild, 1, test.firstChild,
5);
> +    else
> +	   doubleClickAtSelectionStart();

We shouldn't have this kind of platform-branches in tests.
We should abstract UIHelper.doubleTapAt so that there is a single UIHelper
function like
UIHelper.selectWordBoundaryByActivationAt(x, y)

An alternative approach is to use getSelection().modify('extend', 'forward',
'wordboundary')

r- because this makes all these tests behave differently in iOS compared to
other platforms.