[webkit-reviews] review granted: [Bug 193186] Web Inspector: Timelines: DOMContentLoaded and load event lines need to be more obvious : [Attachment 358521] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 19:36:33 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193186: Web Inspector: Timelines: DOMContentLoaded and load event lines
need to be more obvious
https://bugs.webkit.org/show_bug.cgi?id=193186

Attachment 358521: Patch

https://bugs.webkit.org/attachment.cgi?id=358521&action=review




--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358521
  --> https://bugs.webkit.org/attachment.cgi?id=358521
Patch

r=me, but my earlier comments might warrant some small tweak.

Also, in the CPU and Memory timelines there is a legend in the top right
showing a maximum value. Right now the markers show over that legend... maybe
they should show behind it? What do you think.


More information about the webkit-reviews mailing list