[webkit-reviews] review granted: [Bug 193743] Web Inspector: Audit: remove experimental setting : [Attachment 359967] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193743: Web Inspector: Audit: remove experimental setting
https://bugs.webkit.org/show_bug.cgi?id=193743

Attachment 359967: Patch

https://bugs.webkit.org/attachment.cgi?id=359967&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359967
  --> https://bugs.webkit.org/attachment.cgi?id=359967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359967&action=review

> Source/WebInspectorUI/ChangeLog:13
> +	   (WI.Setting.migrateValue):
> +	   Drive-by: add the localStorage key prefix to the key passed into
`WI.Setting.migrateValue`.

This should really be done separately, since you aren't using it here the
drive-by is totally unrelated.

> Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:-53
> -    static isTabAllowed()
> -    {
> -	   return !!window.RuntimeAgent &&
WI.settings.experimentalEnableAuditTab.value;
> -    }

I still think we will want to disable this for ServiceWorkers and JSContexts...
basically only allow this for Web Pages:

    static isTabAllowed()
    {
	return WI.sharedApp.debuggableType === WI.DebuggableType.Web;
    }