[webkit-reviews] review granted: [Bug 193807] [LFC][BFC][MarginCollapsing] Refactor MarginCollapse::updateCollapsedMarginAfter : [Attachment 360069] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 24 19:20:12 PST 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 193807: [LFC][BFC][MarginCollapsing] Refactor
MarginCollapse::updateCollapsedMarginAfter
https://bugs.webkit.org/show_bug.cgi?id=193807
Attachment 360069: Patch
https://bugs.webkit.org/attachment.cgi?id=360069&action=review
--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 360069
--> https://bugs.webkit.org/attachment.cgi?id=360069
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360069&action=review
> Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:492
> + // 7. No need to propagate to parent because its margin is not computed
yet (estimated at most)
Period at end
More information about the webkit-reviews
mailing list