[webkit-reviews] review granted: [Bug 193686] Web Inspector: Audit: add supports key to test/group for compatibility : [Attachment 359965] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193686: Web Inspector: Audit: add supports key to test/group for
compatibility
https://bugs.webkit.org/show_bug.cgi?id=193686

Attachment 359965: Patch

https://bugs.webkit.org/attachment.cgi?id=359965&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359965
  --> https://bugs.webkit.org/attachment.cgi?id=359965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359965&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/AuditTestBase.js:52
> +	   if (!this.supported)

Nit: _supported when used inside this class since the getter is simple.

> Source/WebInspectorUI/UserInterface/Models/AuditTestBase.js:89
> +	   if (!this.supported)

Nit: _supported when used inside this class since the getter is simple.