[webkit-reviews] review granted: [Bug 193787] [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in it's path : [Attachment 360042] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 193787: [webkitdirs] iosSimulatorApplicationsPath may not have
iOS.simruntime in it's path
https://bugs.webkit.org/show_bug.cgi?id=193787

Attachment 360042: Patch

https://bugs.webkit.org/attachment.cgi?id=360042&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 360042
  --> https://bugs.webkit.org/attachment.cgi?id=360042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360042&action=review

> Tools/ChangeLog:3
> +	   [webkitdirs] iosSimulatorApplicationsPath may not have
iOS.simruntime in it's path

s/it's/its/

> Tools/Scripts/webkitdirs.pm:2509
> +    my @runtimes = grep {!/^\./} readdir(RUNTIMES);

Maybe check for ".simruntime" in the name?

> Tools/Scripts/webkitdirs.pm:2511
> +    return File::Spec->catdir($runtimePath, @runtimes ? $runtimes[0] :
"iOS.simruntime", "Contents", "Resources", "RuntimeRoot", "Applications");

I suggest adding a FIXME here. Building the path manually is fragile, and
randomly picking a single runtime path is just weird. We need to find a way to
determine which runtime corresponds to a simulator that we're about to use.