[webkit-reviews] review granted: [Bug 193751] Object Allocation Sinking phase can move a node that walks the stack into a place where the InlineCallFrame is no longer valid : [Attachment 359991] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 09:48:14 PST 2019


Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 193751: Object Allocation Sinking phase can move a node that walks the
stack into a place where the InlineCallFrame is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=193751

Attachment 359991: patch

https://bugs.webkit.org/attachment.cgi?id=359991&action=review




--- Comment #10 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 359991
  --> https://bugs.webkit.org/attachment.cgi?id=359991
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359991&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   walk the stack at the point in the program that it moved the
allocation to.

nit: *to* walk the ...


More information about the webkit-reviews mailing list