[webkit-reviews] review granted: [Bug 193747] ServiceWorkerJob should notify its client in case its job is cancelled : [Attachment 359971] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 24 09:31:35 PST 2019
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 193747: ServiceWorkerJob should notify its client in case its job is
cancelled
https://bugs.webkit.org/show_bug.cgi?id=193747
Attachment 359971: Patch
https://bugs.webkit.org/attachment.cgi?id=359971&action=review
--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 359971
--> https://bugs.webkit.org/attachment.cgi?id=359971
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359971&action=review
r=me
>> Source/WebCore/ChangeLog:11
>> + Covered by existing tests.
>
> Why were there no changes to existing tests then?
To reproduce the leak, you must run WK2 tests with --leaks flag and have it
check the com.apple.WebKit.WebContent.Development process for leaks. (In other
words, this would be caught by a leaks bot if we had a WK2 leaks bot.)
There is an uncommitted patch to do that, but I haven't had time to clean it up
for review. See Bug 193772.
More information about the webkit-reviews
mailing list