[webkit-reviews] review granted: [Bug 193716] [PSON] Flash on back navigation on Mac : [Attachment 360002] patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 193716: [PSON] Flash on back navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=193716

Attachment 360002: patch

https://bugs.webkit.org/attachment.cgi?id=360002&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 360002
  --> https://bugs.webkit.org/attachment.cgi?id=360002
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360002&action=review

r=me with suggestions.

> Source/WebKit/UIProcess/SuspendedPageProxy.cpp:173
> +    shouldKeepOnFailure = m_page.drawingArea() &&
m_page.drawingArea()->type() == DrawingAreaTypeTiledCoreAnimation;

How about shouldDelayClosingOnFailure ?

> Tools/ChangeLog:12
> +	   not sufficient to gurantee we have received all the messages. Wait
for them.

typo: gurantee.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2344
> +	   TestWebKitAPI::Util::run(&receivedMessage);

I think we could simply use TestWebKitAPI::Util::sleep() in the loop here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2439
> +	   TestWebKitAPI::Util::run(&receivedMessage);

ditto.