[webkit-reviews] review granted: [Bug 193746] test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch : [Attachment 359970] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 193746: test_exporter.py: webkitpy.common.system.executive.ScriptError from
create_branch_with_patch
https://bugs.webkit.org/show_bug.cgi?id=193746

Attachment 359970: Patch

https://bugs.webkit.org/attachment.cgi?id=359970&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 359970
  --> https://bugs.webkit.org/attachment.cgi?id=359970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359970&action=review

> Tools/Scripts/webkitpy/w3c/test_exporter.py:-296
> -	       self._git.apply_mail_patch(['--abort'])

I think it was working at some point.
I wonder whether we want to let it as is so that one can manually fix it or use
self._git.reset_hard() to clean the mess.