[webkit-reviews] review granted: [Bug 188742] [GLIB] Expose JavaScriptCore options in GLib public API : [Attachment 359149] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 23 13:34:21 PST 2019
Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 188742: [GLIB] Expose JavaScriptCore options in GLib public API
https://bugs.webkit.org/show_bug.cgi?id=188742
Attachment 359149: Patch
https://bugs.webkit.org/attachment.cgi?id=359149&action=review
--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359149
--> https://bugs.webkit.org/attachment.cgi?id=359149
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359149&action=review
Sorry it took me much longer than usual to get to this.
The options are global, not specific to a particular VM?
For the options JSC_OPTIONS_USE_JIT, JSC_OPTIONS_USE_DFG, JSC_OPTIONS_USE_FTL,
and JSC_OPTIONS_USE_LLINT, it would be nice to have a little bit more
documentation. The only one library users are likely to understand is the plain
JIT, and even then we should probabyl explain it a little bit. DGF, FTL, and
LLINT are probably just alphabet soup even to experienced developers, unless
you're familiar with WebKit internals.
Lastly... use-case. You used to require that new APIs be used by a real
application. Do you have plans to use it somewhere? Surely not adding API just
for the sake of it?
> Source/JavaScriptCore/API/glib/JSCOptions.cpp:33
> + * JavaScript options allow to change the behavior of the JavaScript engine.
allow changing
> Source/JavaScriptCore/API/glib/JSCOptions.cpp:37
> + * Only a few of them are documented, you can use the undocumented options
at
documented;
> Source/JavaScriptCore/API/glib/JSCOptions.cpp:38
> + * your own risk (you can find the list of options in the WebKit source
code).
your own risk. (You can find the list of options in the WebKit source code.)
> Source/JavaScriptCore/API/glib/JSCOptions.cpp:52
> +typedef int32_t int32;
> +typedef size_t size;
typedefs are fine, but a more modern/natural way would be:
using int32 = int32_t;
using size = size_t;
I guess these are for use by the FOR_EACH options macros?
> Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:3376
> + "--jsc-configFile=/tmp/bar",
Does the config file actually get created by the tests? I assume not, since
you're not actually running any JS. But if so, it should be cleaned.
More information about the webkit-reviews
mailing list