[webkit-reviews] review granted: [Bug 192983] [JSC] Reenable baseline JIT on mips : [Attachment 359728] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 192983: [JSC] Reenable baseline JIT on mips
https://bugs.webkit.org/show_bug.cgi?id=192983

Attachment 359728: Patch

https://bugs.webkit.org/attachment.cgi?id=359728&action=review




--- Comment #12 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 359728
  --> https://bugs.webkit.org/attachment.cgi?id=359728
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359728&action=review

LGTM but I'm not a MIPS expert.  I'm ok with landing this if the JSC tests
passes on MIPS (not sure of that's what the jsc-mips EWS bot tests).  It'd be
better if someone else who know MIPS better also give this a review.

> Source/JavaScriptCore/offlineasm/mips.rb:884
> +	   when "loadbs", "loadbsp"
>	       $asm.puts "lb #{mipsFlippedOperands(operands)}"

This is only valid if MIPS is 32-bit only.  loadbs should load and sign extend
up to 32-bit.  On 64-bit, loadbsp should load and sign extend up to 64-bit.