[webkit-reviews] review granted: [Bug 193726] Duplicate global variables: WTF::asciiCaseFoldTable : [Attachment 359901] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 10:47:42 PST 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 193726: Duplicate global variables: WTF::asciiCaseFoldTable
https://bugs.webkit.org/show_bug.cgi?id=193726

Attachment 359901: Patch v1

https://bugs.webkit.org/attachment.cgi?id=359901&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359901
  --> https://bugs.webkit.org/attachment.cgi?id=359901
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=359901&action=review

> Source/WTF/wtf/ASCIICType.h:73
> +extern WTF_EXPORT const unsigned char asciiCaseFoldTable[256];

I think the extern keyword is redundant.


More information about the webkit-reviews mailing list