[webkit-reviews] review granted: [Bug 193721] [GTK] Crash when browsing inspector:// uri without port set : [Attachment 359887] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 193721: [GTK] Crash when browsing inspector:// uri without port set
https://bugs.webkit.org/show_bug.cgi?id=193721

Attachment 359887: Patch

https://bugs.webkit.org/attachment.cgi?id=359887&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359887
  --> https://bugs.webkit.org/attachment.cgi?id=359887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359887&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:95
>	   GUniquePtr<GError> error(g_error_new_literal(WEBKIT_POLICY_ERROR,
WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI, "Cannot show inspector URL: no port
provided"));
>	   webkit_uri_scheme_request_finish_error(request, error.get());
> +	   return;

D: