[webkit-reviews] review granted: [Bug 193699] Compositing updates need to reparent scrolling tree nodes with a changed ancestor : [Attachment 359854] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 193699: Compositing updates need to reparent scrolling tree nodes with a
changed ancestor
https://bugs.webkit.org/show_bug.cgi?id=193699

Attachment 359854: Patch

https://bugs.webkit.org/attachment.cgi?id=359854&action=review




--- Comment #9 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 359854
  --> https://bugs.webkit.org/attachment.cgi?id=359854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359854&action=review

> Source/WebCore/rendering/RenderLayer.h:207
> +	   ChildrenNeedGeometryUpdate			       = 1 << 10, //
This layer's composited children needs a geometry update.

s/needs/need/

> LayoutTests/scrollingcoordinator/reparent-across-compositing-layers.html:14
> +	   function doTest() {

nit: brace should be on the next line

> LayoutTests/scrollingcoordinator/reparent-with-layer-removal.html:14
> +	   function doTest() {

Ditto.