[webkit-reviews] review granted: [Bug 193706] Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit : [Attachment 359857] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 193706: Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
https://bugs.webkit.org/show_bug.cgi?id=193706

Attachment 359857: Patch

https://bugs.webkit.org/attachment.cgi?id=359857&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 359857
  --> https://bugs.webkit.org/attachment.cgi?id=359857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359857&action=review

> Source/WebKit/ChangeLog:45
> +	   Adjust this to take Ref<UndoStep>&&.

Why are we making this change?

> Source/WebKit/UIProcess/WebEditCommandProxy.h:42
> -    static Ref<WebEditCommandProxy> create(WebUndoStepID commandID,
WebCore::EditAction editAction, WebPageProxy* page)
> +    static Ref<WebEditCommandProxy> create(WebUndoStepID commandID, const
String& label, WebPageProxy& page)

Hm... I would have kept WebCore::EditAction for this one but okay.