[webkit-reviews] review granted: [Bug 193704] Introduce CustomUndoStep.h and CustomUndoStep.cpp : [Attachment 359840] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 19:51:39 PST 2019
Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 193704: Introduce CustomUndoStep.h and CustomUndoStep.cpp
https://bugs.webkit.org/show_bug.cgi?id=193704
Attachment 359840: Patch
https://bugs.webkit.org/attachment.cgi?id=359840&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 359840
--> https://bugs.webkit.org/attachment.cgi?id=359840
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359840&action=review
> Source/WebCore/editing/CompositeEditCommand.h:91
> + const String& customUndoLabel() const final { return emptyString(); }
I think a better approach is have the conversion from EditAction to label here.
More information about the webkit-reviews
mailing list