[webkit-reviews] review granted: [Bug 193563] Analyzing a chart that does not exist should not halt whole run-analysis script. : [Attachment 359598] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 19:24:25 PST 2019
Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 193563: Analyzing a chart that does not exist should not halt whole
run-analysis script.
https://bugs.webkit.org/show_bug.cgi?id=193563
Attachment 359598: Patch
https://bugs.webkit.org/attachment.cgi?id=359598&action=review
--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 359598
--> https://bugs.webkit.org/attachment.cgi?id=359598
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359598&action=review
> Websites/perf.webkit.org/public/v3/models/measurement-set.js:86
> + if (promise && callback) {
> promise.then(callback, callback);
> - else {
> + } else if (!promise) {
It would be cleaner to nest if's as in:
if (promise) {
if (callback)
~
} else {
~
}
More information about the webkit-reviews
mailing list