[webkit-reviews] review granted: [Bug 193262] Web Inspector: expose Audit and Recording versions to the frontend : [Attachment 359790] [Patch] Protocol Version

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193262: Web Inspector: expose Audit and Recording versions to the frontend
https://bugs.webkit.org/show_bug.cgi?id=193262

Attachment 359790: [Patch] Protocol Version

https://bugs.webkit.org/attachment.cgi?id=359790&action=review




--- Comment #17 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359790
  --> https://bugs.webkit.org/attachment.cgi?id=359790
[Patch] Protocol Version

View in context: https://bugs.webkit.org/attachment.cgi?id=359790&action=review

r=me

> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:306
> +	       if (agent.VERSION !== undefined)
> +		   clone.VERSION = agent.VERSION;

Is this necessary?

    var foo = {version:1};
    var bar = Object.create(foo);
    assert(bar.version === 1); // true

> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:331
> +	       if (agent.VERSION !== undefined)
> +		   clone.VERSION = agent.VERSION;

Ditto.