[webkit-reviews] review granted: [Bug 193687] Long presses on YouTube links incorrectly trigger a load : [Attachment 359791] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 193687: Long presses on YouTube links incorrectly trigger a load
https://bugs.webkit.org/show_bug.cgi?id=193687

Attachment 359791: Patch

https://bugs.webkit.org/attachment.cgi?id=359791&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 359791
  --> https://bugs.webkit.org/attachment.cgi?id=359791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359791&action=review

>>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1351
>>> +- (void)_cancelWebGestureRecognizer
>> 
>> Still not sure why the method. Are you thinking it will have more callers?
>> And my other complaint about the method name stills stands.
> 
> They are this is the Web Gesture in all other instances, because it is the
gesture that passes the touches to the web. I think this helps clear up that is
this the gesture we are talking about. 
> And while there are no additional callers today, there might be in the
future, so I'd like to encapsulate the need for feature defines. Also, several
other gestures use this exact layout of code to do the exact same thing.

I don't think it's ever called just "Web", that would be crazy. It is
"WebTouchEvent" in UIKit, and "TouchEvent" in WebKit. You can decide what to
call it.