[webkit-reviews] review denied: [Bug 192652] REGRESSION(r238599): Web Inspector: Clicking on text doesn't move text caret when editing innerHTML/tagName/attribute : [Attachment 359294] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 192652: REGRESSION(r238599): Web Inspector: Clicking on text doesn't move
text caret when editing innerHTML/tagName/attribute
https://bugs.webkit.org/show_bug.cgi?id=192652

Attachment 359294: Patch

https://bugs.webkit.org/attachment.cgi?id=359294&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 359294
  --> https://bugs.webkit.org/attachment.cgi?id=359294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359294&action=review

r-, see attachment 359804 (comment #9)

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:649
>	   // Prevent selecting the nearest word on double click.

Should we only be doing this when we aren't editing?  I can imagine that it
would be very useful to double-click to select a specific class name (in the
space-separated list) when editing.