[webkit-reviews] review granted: [Bug 193696] Web Inspector: Network Waterfall column should redraw when adding/removing new columns : [Attachment 359797] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 193696: Web Inspector: Network Waterfall column should redraw when
adding/removing new columns
https://bugs.webkit.org/show_bug.cgi?id=193696

Attachment 359797: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=359797&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 359797
  --> https://bugs.webkit.org/attachment.cgi?id=359797
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=359797&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:1073
> +	       needsReloadOnResize: true,

And this is a perfect example of why I love optional objects in constructors 😍

> Source/WebInspectorUI/UserInterface/Views/Table.js:494
> +	   // Now populate columns that may be sensitive to resizes.

Could you extract this logic into a separate function so that it can be called
(instead of copied) by `hideColumn`?

> Source/WebInspectorUI/UserInterface/Views/Table.js:498
> +		       this.reloadVisibleColumnCells(visibleColumn);

Is it necessary to do all this work as soon as a new column is added, or can we
leverage the layout system to wait until we need to actually display it (this
also applies to the `this._delegate.tablePopulateCell` loop)?