[webkit-reviews] review granted: [Bug 193688] IndexedDB: leak WebIDBConnectionToServer in layout tests : [Attachment 359781] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 15:33:13 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 193688: IndexedDB: leak WebIDBConnectionToServer in layout tests
https://bugs.webkit.org/show_bug.cgi?id=193688

Attachment 359781: Patch

https://bugs.webkit.org/attachment.cgi?id=359781&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 359781
  --> https://bugs.webkit.org/attachment.cgi?id=359781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359781&action=review

r=me

> Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.h:149
> +    WeakPtr<IDBConnectionToServerDelegate> m_delegate;

What is the consequence when this pointer becomes null? Is that OK?


More information about the webkit-reviews mailing list