[webkit-reviews] review granted: [Bug 193687] Long presses on YouTube links incorrectly trigger a load : [Attachment 359786] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 193687: Long presses on YouTube links incorrectly trigger a load
https://bugs.webkit.org/show_bug.cgi?id=193687

Attachment 359786: Patch

https://bugs.webkit.org/attachment.cgi?id=359786&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 359786
  --> https://bugs.webkit.org/attachment.cgi?id=359786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359786&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:761
> +- (void)cancel;

Was this here forever into the past, or do you need some ifdefs?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1354
> +- (void)_cancelWebGestureRecognizer
> +{
> +    [_touchEventGestureRecognizer cancel];
> +}

Why the indirection? Why "Web" gesture recognizer? Aren't they all technically
about the web? :D I could see _cancelTouchEventsGestureRecognizer or something,
but also think you just don't need this function.