[webkit-reviews] review granted: [Bug 193227] Web Inspector: Audit: provide a way to get related Accessibility properties for a given node : [Attachment 359775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 15:00:48 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193227: Web Inspector: Audit: provide a way to get related Accessibility
properties for a given node
https://bugs.webkit.org/show_bug.cgi?id=193227

Attachment 359775: Patch

https://bugs.webkit.org/attachment.cgi?id=359775&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359775
  --> https://bugs.webkit.org/attachment.cgi?id=359775
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359775&action=review

r=me

> LayoutTests/inspector/audit/run-accessibility.html:21
> +	   return JSON.stringify(mapped);

You could prettyify this `JSON.stringify(mapped, null, 4)` which would make
failure diffs easy to understand if a single property changed.


More information about the webkit-reviews mailing list