[webkit-reviews] review granted: [Bug 193680] Regression(r240178) Some API tests are crashing : [Attachment 359769] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 13:33:58 PST 2019
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 193680: Regression(r240178) Some API tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=193680
Attachment 359769: Patch
https://bugs.webkit.org/attachment.cgi?id=359769&action=review
--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 359769
--> https://bugs.webkit.org/attachment.cgi?id=359769
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359769&action=review
> Source/WebKit/WebProcess/UserContent/WebUserContentController.h:125
> + typedef HashMap<RefPtr<InjectedBundleScriptWorld>,
Vector<std::pair<uint64_t, RefPtr<WebUserMessageHandlerDescriptorProxy>>>>
WorldToUserMessageHandlerVectorMap;
I think it would be nice to give this pair's first and second members better
names and name uint64_t.
More information about the webkit-reviews
mailing list