[webkit-reviews] review granted: [Bug 193669] [build.webkit.org] Unit-test failure after r237113 : [Attachment 359742] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 12:11:54 PST 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 193669: [build.webkit.org] Unit-test failure after r237113
https://bugs.webkit.org/show_bug.cgi?id=193669

Attachment 359742: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=359742&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359742
  --> https://bugs.webkit.org/attachment.cgi?id=359742
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359742&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:42
> -	   if platform == "gtk" and additionalArguments !=
["--no-experimental-features"]:
> +	   if platform == "gtk" and "--no-experimental-features" not in
(additionalArguments or []):

Why do you need the "or []"?


More information about the webkit-reviews mailing list