[webkit-reviews] review denied: [Bug 193669] [build.webkit.org] Unit-test failure after r237113 : [Attachment 359734] Unit-test fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 08:50:01 PST 2019


Michael Catanzaro <mcatanzaro at igalia.com> has denied Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 193669: [build.webkit.org] Unit-test failure after r237113
https://bugs.webkit.org/show_bug.cgi?id=193669

Attachment 359734: Unit-test fix

https://bugs.webkit.org/attachment.cgi?id=359734&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359734
  --> https://bugs.webkit.org/attachment.cgi?id=359734
Unit-test fix

Since this is not the expected result, could we please do the fix you proposed
in bug #190581 instead:

"""
If this step is not expected, factories.py L42 should be changed to something
like:

    if platform == "gtk" and "--no-experimental-features" not in
additionalArguments:
"""


More information about the webkit-reviews mailing list