[webkit-reviews] review requested: [Bug 167941] [WPE][GTK] Enable support for CONTENT_EXTENSIONS : [Attachment 359725] WIP Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 01:50:21 PST 2019


Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 167941: [WPE][GTK] Enable support for CONTENT_EXTENSIONS
https://bugs.webkit.org/show_bug.cgi?id=167941

Attachment 359725: WIP Patch v3

https://bugs.webkit.org/attachment.cgi?id=359725&action=review




--- Comment #54 from Adrian Perez <aperez at igalia.com> ---
Created attachment 359725

  --> https://bugs.webkit.org/attachment.cgi?id=359725&action=review

WIP Patch v3


This version of the patch is rebased on top of the patch for bug #193622
(which needs to be applied first, so the EWS bots will fail), and it now
includes proper API documentation, changes names of functions a bit to
make things consistent (e.g. _get_identifier instead of _get_name to get
the identifier for a filter), made the style checker happy, and addresses
most of the review comments (not all, tho).

I am still undecided on the GBytes vs. char* parameters for the JSON
filter source. How about making webkit_content_filter_manager_compile()
accept a GBytes *and* also providing a helper function
webkit_content_filter_manager_compile_string() which accepts a string
and calls the GBytes version under the hood?


More information about the webkit-reviews mailing list