[webkit-reviews] review granted: [Bug 193657] [css-grid] Issue with abspos element which containing block is the grid container : [Attachment 359703] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 193657: [css-grid] Issue with abspos element which containing block is the
grid container
https://bugs.webkit.org/show_bug.cgi?id=193657

Attachment 359703: Patch

https://bugs.webkit.org/attachment.cgi?id=359703&action=review




--- Comment #2 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 359703
  --> https://bugs.webkit.org/attachment.cgi?id=359703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359703&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1760
> +// TODO: SetLogicalPositionForChild has only one caller, consider its

We use FIXME for this type of comments. Also, there is no need to break the
line.

> Source/WebCore/rendering/RenderGrid.cpp:1764
> +    // "In the positioning phase [...] calculations are performed according
to the

We can use longer lines and avoid such large number of lines in this comment.

> Source/WebCore/rendering/RenderGrid.cpp:1776
> +    // 'setLogicalLeft' and 'setLogicalTop' only take into account the
child's

Ditto