[webkit-reviews] review granted: [Bug 193652] DoesGC rule is wrong for nodes with BigIntUse : [Attachment 359701] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 193652: DoesGC rule is wrong for nodes with BigIntUse
https://bugs.webkit.org/show_bug.cgi?id=193652

Attachment 359701: Patch

https://bugs.webkit.org/attachment.cgi?id=359701&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359701
  --> https://bugs.webkit.org/attachment.cgi?id=359701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359701&action=review

r=me

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:388
> +	   return node->binaryUseKind() == BigIntUse;

Might as well return true here. Because the clobberize check above, we won’t
reach here. However, it’s nicer just to say true IMO