[webkit-reviews] review granted: [Bug 193607] C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated : [Attachment 359612] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 08:55:49 PST 2019


Alex Christensen <achristensen at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 193607: C strings in ClientCertificateAuthenticationXPCConstants.h are
duplicated
https://bugs.webkit.org/show_bug.cgi?id=193607

Attachment 359612: Patch v3

https://bugs.webkit.org/attachment.cgi?id=359612&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 359612
  --> https://bugs.webkit.org/attachment.cgi?id=359612
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=359612&action=review

>
Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCCon
stants.h:32
> +struct ClientCertificateAuthentication {

Isn't this more of a namespace?


More information about the webkit-reviews mailing list