[webkit-reviews] review granted: [Bug 186030] Set Origin header value to null rather than omitting it : [Attachment 359642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 06:54:49 PST 2019


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 186030: Set Origin header value to null rather than omitting it
https://bugs.webkit.org/show_bug.cgi?id=186030

Attachment 359642: Patch

https://bugs.webkit.org/attachment.cgi?id=359642&action=review




--- Comment #33 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 359642
  --> https://bugs.webkit.org/attachment.cgi?id=359642
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359642&action=review

LGTM but do you know why the Windows tests are failing? I wonder if a similar
change should be done in windows-specific code.

> LayoutTests/imported/w3c/ChangeLog:8
> +	   Update improved test result.

This is also chaning expectations in http/tests/security to match the new
behavior.


More information about the webkit-reviews mailing list