[webkit-reviews] review granted: [Bug 193649] Move delegatesScrolling() tests to lower level conversion function in ScrollView : [Attachment 359679] patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 193649: Move delegatesScrolling() tests to lower level conversion function
in ScrollView
https://bugs.webkit.org/show_bug.cgi?id=193649

Attachment 359679: patch

https://bugs.webkit.org/attachment.cgi?id=359679&action=review




--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 359679
  --> https://bugs.webkit.org/attachment.cgi?id=359679
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review

This LGTMs, thanks!

> Source/WebCore/platform/ScrollView.cpp:-864
> -    

This is reverting what was added in bug 186956. I guess your patch is the right
way to fix it.

> Source/WebCore/platform/ScrollView.cpp:-877
> -

I'm curious if this will fix bug 184297 as the patch I uploaded there does
similar thing.