[webkit-reviews] review granted: [Bug 193487] [WHLSL] Add the statement behavior checker : [Attachment 359645] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 193487: [WHLSL] Add the statement behavior checker
https://bugs.webkit.org/show_bug.cgi?id=193487

Attachment 359645: Patch

https://bugs.webkit.org/attachment.cgi?id=359645&action=review




--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 359645
  --> https://bugs.webkit.org/attachment.cgi?id=359645
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359645&action=review

> Source/WebCore/ChangeLog:19
> +	   * Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp: Added.
> +	   (WebCore::WHLSL::StatementBehaviorChecker::takeFunctionBehavior):
> +	   (WebCore::WHLSL::checkStatementBehavior):
> +	   * Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h: Added.
> +	   * Sources.txt:
> +	   * WebCore.xcodeproj/project.pbxproj:

Why doesn't this mention WHLSLLoopChecker's removal?

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:145
> +	       reduction = OptionSet<Behavior>::fromRaw(reduction.toRaw() |
b.toRaw());

I believe you can do reduction |= b;
constexpr friend OptionSet operator|(OptionSet lhs, OptionSet rhs)

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:171
> +	   m_stack.append(OptionSet<Behavior>::fromRaw(b.toRaw() |
bPrime.toRaw()));

Ditto.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:201
> +	       reduction = OptionSet<Behavior>::fromRaw(reduction.toRaw() |
b.toRaw());

Ditto.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:207
> +	   m_stack.append(OptionSet<Behavior>::fromRaw(reduction.toRaw() |
b.toRaw()));

Ditto.