[webkit-reviews] review denied: [Bug 192664] [BigInt] Add ValueBitLShift into DFG : [Attachment 359605] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 20 14:46:58 PST 2019
Saam Barati <sbarati at apple.com> has denied Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 192664: [BigInt] Add ValueBitLShift into DFG
https://bugs.webkit.org/show_bug.cgi?id=192664
Attachment 359605: Patch
https://bugs.webkit.org/attachment.cgi?id=359605&action=review
--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359605
--> https://bugs.webkit.org/attachment.cgi?id=359605
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359605&action=review
> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:103
> + case ValueBitLShift:
same comment as I've written in other bugs. Should return true if BigIntUse.
More information about the webkit-reviews
mailing list