[webkit-reviews] review granted: [Bug 193612] [JSC] Shrink data structure size in JSC/heap : [Attachment 359603] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 193612: [JSC] Shrink data structure size in JSC/heap
https://bugs.webkit.org/show_bug.cgi?id=193612

Attachment 359603: Patch

https://bugs.webkit.org/attachment.cgi?id=359603&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359603
  --> https://bugs.webkit.org/attachment.cgi?id=359603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359603&action=review

> Source/JavaScriptCore/heap/Heap.h:581
> +    Markable<CollectionScope, EnumMarkableTraits<CollectionScope>>
m_collectionScope;

I really hate the name of this "Markable" class. Why don't we just encode this
stuff in Optional via some extra type parameter?