[webkit-reviews] review granted: [Bug 193613] [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered. : [Attachment 359610] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 19 09:52:18 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 193613: [LFC][Floats] Ensure that floats in FloatingContext::m_floats are
always horizontally ordered.
https://bugs.webkit.org/show_bug.cgi?id=193613

Attachment 359610: Patch

https://bugs.webkit.org/attachment.cgi?id=359610&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 359610
  --> https://bugs.webkit.org/attachment.cgi?id=359610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359610&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:101
> +	   if (isLeftPositioned^floatItem.isLeftPositioned())

!= ?


More information about the webkit-reviews mailing list