[webkit-reviews] review granted: [Bug 193596] Cleanup undo options : [Attachment 359551] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 193596: Cleanup undo options
https://bugs.webkit.org/show_bug.cgi?id=193596

Attachment 359551: Patch

https://bugs.webkit.org/attachment.cgi?id=359551&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 359551
  --> https://bugs.webkit.org/attachment.cgi?id=359551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359551&action=review

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=193596

Radar link?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:161
> +enum WKUndoOption {

: uint8_t

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:162
> +    WKUndoTypeDefault =  0,

Nit - extra space before 0 here.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5109
> +    if
(_suppressSelectionAssistantReasons.contains(WebKit::FocusedElementIsTransparen
tOrFullyClipped))

We probably want to return Smaller for WebKit::FocusedElementIsTooSmall too.