[webkit-reviews] review granted: [Bug 193583] CSS auto focus-ring outlines don't render on iOS : [Attachment 359522] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 193583: CSS auto focus-ring outlines don't render on iOS
https://bugs.webkit.org/show_bug.cgi?id=193583

Attachment 359522: Patch

https://bugs.webkit.org/attachment.cgi?id=359522&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 359522
  --> https://bugs.webkit.org/attachment.cgi?id=359522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359522&action=review

> Source/WebCore/platform/ios/ColorIOS.mm:37
> +    // FIXME: Make this work for a UIColor that was created from a pattern.

Also make it work with DispayP3 colors.

> Source/WebCore/platform/ios/ColorIOS.mm:46
> +    static const double scaleFactor = nextafter(256.0, 0.0);
> +    return makeRGBA(scaleFactor * redComponent, scaleFactor *
greenComponent, scaleFactor * blueComponent, scaleFactor * alpha);

Why not makeRGBA32FromFloats()?