[webkit-reviews] review granted: [Bug 193539] Implement asynchronous frame scrolling for iOS : [Attachment 359478] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 193539: Implement asynchronous frame scrolling for iOS
https://bugs.webkit.org/show_bug.cgi?id=193539

Attachment 359478: patch

https://bugs.webkit.org/attachment.cgi?id=359478&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 359478
  --> https://bugs.webkit.org/attachment.cgi?id=359478
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359478&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3415
> +#if PLATFORM(IOS)

if PLATFORM(IOS_FAMILY)

Ideally this wouldn't be a platform #ifdef, but something else.

>
LayoutTests/platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrol
ling-expected.txt:46
> -		     (coverage rect 0.00, 0.00 300.00 x 150.00)
> +		     (coverage rect -10.00, -10.00 800.00 x 600.00)

This seems odd.