[webkit-reviews] review requested: [Bug 193576] [GTK][WPE] Make debug-test-runner work : [Attachment 359495] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 193576: [GTK][WPE] Make debug-test-runner work
https://bugs.webkit.org/show_bug.cgi?id=193576

Attachment 359495: Patch

https://bugs.webkit.org/attachment.cgi?id=359495&action=review




--- Comment #1 from Adrian Perez <aperez at igalia.com> ---
Created attachment 359495

  --> https://bugs.webkit.org/attachment.cgi?id=359495&action=review

Patch


Note that I have almost never touched Perl code, so hopefully this
patch is not too bad O:-)

With the changes suggested in the patch it is possible to get
WebKitTestRunner under GDB on GNU/Linux for many layout tests.
Note that the intention is *not* to replicate all of possible
modes of operation of run-webkit-tests, so for example tests
which need a running HTTP server will not work. Most tests
will, however, and having the script working is already being
handy for me to investigate assertions. I think it would be
valuable to have these changes landed upstream.

Tu use, do something like:

  % build-webkit --debug --gtk
  % debug-test-runner --debug --gtk LayoutTests/fast/dom/location-hash.html

Note that you will need a running X11 server or Wayland compositor
accordingly. No attempt is made at running Xvfb or headless Weston.