[webkit-reviews] review canceled: [Bug 193565] iOS: Updating input mode should update the software keyboard : [Attachment 359452] WIP

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled  review:
Bug 193565: iOS: Updating input mode should update the software keyboard
https://bugs.webkit.org/show_bug.cgi?id=193565

Attachment 359452: WIP

https://bugs.webkit.org/attachment.cgi?id=359452&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 359452
  --> https://bugs.webkit.org/attachment.cgi?id=359452
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=359452&action=review

This patch is only a WIP, as it wasn't marked for review and it's also still
missing ChangeLog entries and tests.

That being said, the codechange itself also looks good to me.

> Source/WebCore/html/HTMLElement.cpp:457
> +	      
document.page()->chrome().client().focusedElementDidChangeInputMode(*this,
canonicalInputMode());

Does something guarantee that page is non-null here?

> Source/WebKit/Scripts/webkit/messages.py:410
> +	   'WebCore::InputMode': ['<WebCore/InputMode.h>'],

A little surprising that this is needed! I thought the code generator would (by
default) try to include <WebCore/InputMode.h> based on the type of the IPC
argument, but maybe this isn't the case for enum class types.