[webkit-reviews] review granted: [Bug 193570] [Flatpak] Missing KeyboardInterrupt exception handler : [Attachment 359483] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 07:25:58 PST 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 193570: [Flatpak] Missing KeyboardInterrupt exception handler
https://bugs.webkit.org/show_bug.cgi?id=193570

Attachment 359483: patch

https://bugs.webkit.org/attachment.cgi?id=359483&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359483
  --> https://bugs.webkit.org/attachment.cgi?id=359483
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359483&action=review

> Tools/flatpak/flatpakutils.py:771
> +	       except KeyboardInterrupt:
> +		   return 0

I wish python would just do something sane by default....

This would probably be desirable in the run_gdb() function as well.


More information about the webkit-reviews mailing list