[webkit-reviews] review granted: [Bug 193494] [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas : [Attachment 359437] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 17:59:55 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 193494: [iOS] Content offset jumps erratically when autoscrolling near
scroll view content inset areas
https://bugs.webkit.org/show_bug.cgi?id=193494

Attachment 359437: Patch v2

https://bugs.webkit.org/attachment.cgi?id=359437&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 359437
  --> https://bugs.webkit.org/attachment.cgi?id=359437
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=359437&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2555
> +	       // Even though content insets do not represent content, we
consider them as part of the visible rect
> +	       // to allow ourselves to scroll into content insets.

I think it would be better to just remove this comment.


More information about the webkit-reviews mailing list