[webkit-reviews] review granted: [Bug 193557] Audit bytecode fields and ensure that LLInt instructions for accessing them are appropriate. : [Attachment 359424] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 193557: Audit bytecode fields and ensure that LLInt instructions for
accessing them are appropriate.
https://bugs.webkit.org/show_bug.cgi?id=193557

Attachment 359424: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=359424&action=review




--- Comment #3 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 359424
  --> https://bugs.webkit.org/attachment.cgi?id=359424
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=359424&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1331
> +    loadp OpGetByIdDirect::Metadata::m_structureID[t5], t1

I prefer using loadi for StructureID, but either is OK to me if it is
consistent.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:918
> +    loadi CodeBlock::m_numParameters[temp1], temp1

Nice