[webkit-reviews] review denied: [Bug 193494] [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas : [Attachment 359379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 17 14:31:18 PST 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has denied review:
Bug 193494: [iOS] Content offset jumps erratically when autoscrolling near
scroll view content inset areas
https://bugs.webkit.org/show_bug.cgi?id=193494
Attachment 359379: Patch
https://bugs.webkit.org/attachment.cgi?id=359379&action=review
--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 359379
--> https://bugs.webkit.org/attachment.cgi?id=359379
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359379&action=review
> Source/WebCore/rendering/RenderLayer.cpp:2558
> + auto& unobscuredInsets = page().unobscuredContentInsets();
Rather than fetching insets form Page and getting unobscuredContentRect() and
doing math, I'd prefer that FrameView have a single function to returned the
rect expanded by insets.
More information about the webkit-reviews
mailing list